Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First steps to shading sbt-scalafmt #1218

Merged
merged 5 commits into from
Jun 10, 2018
Merged

First steps to shading sbt-scalafmt #1218

merged 5 commits into from
Jun 10, 2018

Conversation

olafurpg
Copy link
Member

@olafurpg olafurpg commented Jun 10, 2018 •
edited
Loading

Towards #1200

  • adds new scalafmt-cli-shaded module that is a fatjar with all scalafmt dependencies shaded in the package org.scalafmt.shaded
  • remove sbt plugin from the build since it will be moved into a separate repo

olafurpg added 5 commits June 10, 2018 18:02
@olafurpg
Add new cli-shaded module to fix sbt-scalafmt
f8380eb 
This is
@olafurpg
Remove sbt plugins.
f5e67fe 
The sbt plugin will be moved to a separate repo.
@olafurpg
Rename to scalafmt-big
a109be0 
- don't embed scala-library
- remove ci-sbt command
@olafurpg
Skip mima in scalafmt-big
185f07a
@olafurpg
Remove confusing 'Downloaded' message
6d8bfc4
@olafurpg olafurpg merged commit 7181d10 into scalameta:master Jun 10, 2018
@olafurpg olafurpg deleted the shade branch June 10, 2018 20:40
This was referenced Jun 10, 2018
Closed
Closed
@ches
Copy link
Contributor

ches commented Jun 12, 2018

Thank you for shaving this yak. It has resolved a case of #1200 for me.

@olafurpg
Copy link
Member Author

Thanks for reporting back @ches I will close #1200 as fixed then 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olafurpg @ches